-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jdk): upgrade to JDK21 #651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
dependencies
Pull requests that update a dependency file
chore
Refactor, rename, cleanup, etc.
safe-to-test
labels
Sep 16, 2024
github-actions
bot
added
dependent
needs-triage
Needs thorough attention from code reviewers
and removed
dependent
labels
Sep 16, 2024
andrewazores
removed
the
needs-triage
Needs thorough attention from code reviewers
label
Sep 16, 2024
7 tasks
andrewazores
changed the title
chore(jdk): upgrade to JDK21 on UBI9
chore(jdk): upgrade to JDK21
Sep 17, 2024
This PR/issue depends on: |
andrewazores
force-pushed
the
ubi9-jdk21
branch
from
September 30, 2024 15:44
53621a6
to
bb20e1e
Compare
/build_test |
github-actions
bot
added
the
needs-triage
Needs thorough attention from code reviewers
label
Sep 30, 2024
Workflow started at 9/30/2024, 11:45:29 AM. View Actions Run. |
andrewazores
removed
the
needs-triage
Needs thorough attention from code reviewers
label
Sep 30, 2024
CI build and push: At least one test failed ❌ |
^ failure because the change to update the CI is included in this changeset too, so the CI runner is still trying to use JDK 17 to build and run this, but it requires 21+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Refactor, rename, cleanup, etc.
dependencies
Pull requests that update a dependency file
safe-to-test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Depends on #609
Depends on cryostatio/cryostat-reports#275
Depends on cryostatio/jfr-datasource#326
Based on #609
Fixes #364
Description of the change:
This change allows an environment variable to be configured so that...
Motivation for the change:
This change is helpful because users may want to...
How to manually test: